Re: [PATCH] media: imx: imx7_mipi_csis: convert some switch cases to the default
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2021-06-01 12:46:59
Also in:
linux-arm-kernel, linux-media, lkml
Hi Tom, Thank you for the patch. On Mon, May 31, 2021 at 10:43:00AM -0700, trix@redhat.com wrote:
From: Tom Rix <trix@redhat.com>
Static analysis reports this false positive
imx7-mipi-csis.c:1027:2: warning: 4th function call argument is
an uninitialized value
The variable 'align' is falsely reported as uninitialized.
Even though all the cases are covered in the
switch (csis_fmt->width % 8) {
Because there is no default case, it is reported as uninialized.
Improve the switch by converting the most numerous set of cases
to the default and silence the false positive.
Signed-off-by: Tom Rix <trix@redhat.com>Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk ↗ jump to hunk
--- drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c index d573f3475d28..330f283030ec 100644 --- a/drivers/staging/media/imx/imx7-mipi-csis.c +++ b/drivers/staging/media/imx/imx7-mipi-csis.c@@ -1016,10 +1016,8 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd, case 6: align = 2; break; - case 1: - case 3: - case 5: - case 7: + default: + /* 1, 3, 5, 7 */ align = 3; break; }
-- Regards, Laurent Pinchart