On Mon, Jun 07, 2021 at 09:11:13AM +0200, Sergio Paracuellos wrote:

Hi Dan,

On Mon, Jun 7, 2021 at 8:59 AM Dan Carpenter [off-list ref] wrote:

quoted

On Sat, Jun 05, 2021 at 09:30:23AM +0200, Sergio Paracuellos wrote:

quoted

Properties 'clocks', 'resets' and 'phys' have been moved from parent
node to the root port childs. Hence we have to adapt the way device
tree is parsed in driver code to properly align things and make all
the stuff work.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

It sounds like this commit needs a fixes tag?  What does "to properly
align things and make all the stuff work." in terms of what the user
sees?

I submitted this driver to get mainlined and when bindings have been
reviewed I've been told to move this stuff into child nodes. Until now
all was also being properly working but with these properties defined
in the parent node. So I don't think any Fixes tag is needed here. So
hopefully changes on this patchset are the last need to get this
properly mainlined. I've been told to just make a 'git mv' without
zero changes from the staging driver, that's why I am submitting
changes to staging before.

I'm really trying to understand how this affects the user experience but
it sounds like you don't know either but you were told it was the
correct thing and it seems to work?  That's not ideal but I can live
with it I guess...  I guess hopefully no change but it's just a
correctness issue?

Btw, we moved from devm_reset_control_get_exclusive() to
of_reset_control_get_exclusive().  Does that mean we need to add a call
to reset_control_put() in the remove() path?

regards,
dan carpenter