Re: [PATCH v1 1/6] i2c: acpi: Export i2c_acpi_find_client_by_adev() for users
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-05-28 09:25:16
Also in:
linux-acpi, linux-i2c, linux-media, lkml
On Fri, May 28, 2021 at 12:23:31PM +0300, Andy Shevchenko wrote:
On Thu, May 27, 2021 at 10:26:33PM +0200, Wolfram Sang wrote:quoted
On Wed, May 26, 2021 at 03:43:17PM +0300, Andy Shevchenko wrote:quoted
There is at least one user that will gain from the i2c_acpi_find_client_by_adev() being exported.No objections per se. But as the user is in staging, I want to ask if the use there is really a solution we would also accept outside of staging? Or is it a hack?The similar OF API is exported for users, although amount of users and their locations are different. The AtomISP driver is not in the best shape, I agree, but for now any possible steps to make it better would be good steps in my opinion. Later we may see if we can do this piece of code differently (IIRC current way is probably the best taking into account legacy platforms support).
Btw, we may move all current exports from I2C ACPI to its own namespace, then we won't really care if it'e exported or not, only explicit consumers will use it. -- With Best Regards, Andy Shevchenko