Re: [PATCH] staging: rtl8723bs: core: rtw_mlme_ext.c: Remove set but unused variable
From: Dan Carpenter <hidden>
Date: 2021-05-24 09:26:35
Also in:
lkml
On Sun, May 23, 2021 at 07:30:42PM +0200, Fabio M. De Francesco wrote:
quoted hunk ↗ jump to hunk
Removed set but unused 'reason_code' variable. Issue detected by GCC running with the warning option -Wunused-but-set-variable. Removed its use as a storage of the return value of get_unaligned_le16(), which has been left as is because it has side effects on the argument it takes. Signed-off-by: Fabio M. De Francesco <redacted> --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 9fc612fb736f..a13b3ec42bc9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c@@ -1721,7 +1721,7 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra struct recv_reorder_ctrl *preorder_ctrl; unsigned char *frame_body; unsigned char category, action; - unsigned short tid, status, reason_code = 0; + unsigned short tid, status; struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info); u8 *pframe = precv_frame->u.hdr.rx_data;@@ -1791,8 +1791,7 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra psta->htpriv.candidate_tid_bitmap &= ~BIT((frame_body[3] >> 4) & 0xf); - /* reason_code = frame_body[4] | (frame_body[5] << 8); */ - reason_code = get_unaligned_le16(&frame_body[4]); + get_unaligned_le16(&frame_body[4]);
It doesn't have any side effects. Just delete it too. regards, dan carpenter