Thread (9 messages) 9 messages, 3 authors, 2021-05-19

Re: [PATCH] staging: android: ashmem: Declared file operation with 'const' keyword

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-05-19 14:55:52
Also in: lkml

On Wed, May 19, 2021 at 08:06:14PM +0530, Hriday Hegde wrote:
On 19-05-2021 15:20, Greg Kroah-Hartman wrote:
quoted
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

http://daringfireball.net/2007/07/on_top

On Wed, May 19, 2021 at 03:00:08PM +0530, Hriday Hegde wrote:
quoted
I am not really sure how to do that and how to reflect it in the patch i followed what was taught in the Beginners course and it does not mention building. I know i need to test it out but is running 'patch -p1 < x.patch what i need to do?
That does not build the code you changed, right?

I'm sure whatever course you took, it did reference the fact that you
need to ensure that your change actually works properly by the very
least being able to be compiled correctly.  Please go over those
instructions again.

good luck!

greg k-h
I am using the A Beginner's Guide to Linux Kernel Development (LFD103) by the linux foundation for this but i cant find any commands to as to build and test , the only way i tried compiling is with a custom Makefile and it didn't work, i've got a few errors so the const keyword might not work here since the variable is being written to.
That is correct, when compiling (i.e. building), the compiler shows that
this is not a correct change.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help