Thread (3 messages) 3 messages, 3 authors, 2021-03-31

Re: [PATCH -next] staging: rtl8723bs: core: Remove unused variable 'res'

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-03-31 10:30:10
Also in: kernel-janitors, lkml

On Wed, Mar 31, 2021 at 04:12:43PM +0800, Xu Jia wrote:
quoted hunk ↗ jump to hunk
The variable 'res' is not used in function, this commit
remove it to fix the warning.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Xu Jia <redacted>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index f96dd0b40e04..00b83919a9a3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -533,7 +533,6 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)
 u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
 {
 	struct sta_info *psta;
-	u32 res = _SUCCESS;
 	NDIS_802_11_MAC_ADDRESS	bcast_addr = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 
 	struct	sta_priv *pstapriv = &padapter->stapriv;
@@ -542,15 +541,12 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
 	psta = rtw_alloc_stainfo(pstapriv, bcast_addr);
 
 	if (!psta) {
-		res = _FAIL;
 		RT_TRACE(_module_rtl871x_sta_mgt_c_, _drv_err_, ("rtw_alloc_stainfo fail"));
-		goto exit;
+		return _FAIL;
You just changed the logic here, that's not a good thing for a "robot"
to be doing at all.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help