Re: [PATCH -next] staging: rtl8723bs: core: fix error return
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-03-26 14:09:00
Also in:
lkml
On Thu, Mar 25, 2021 at 04:30:41PM +0800, Xu Jia wrote:
quoted hunk ↗ jump to hunk
Function rtw_init_bcmc_stainfo() is always return success. Variable 'ret' set but not used. Reported-by: Hulk Robot <redacted> Signed-off-by: Xu Jia <redacted> --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index f96dd0b40e04..7b578192adf5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c@@ -551,7 +551,7 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter) psta->mac_id = 1; exit: - return _SUCCESS; + return res; }
You just changed the logic of this function, now it can return a failure. Is that ok? have you tested it when this fails? Given that I do not think anyone actually tests this value, should this function just return void instead? thanks, greg k-h