[PATCH v2 14/20] mtd: mchp23k256: Warn about failure to unregister mtd device
From: Uwe Kleine-König <hidden>
Date: 2021-10-12 15:40:15
Subsystem:
memory technology devices (mtd), the rest · Maintainers:
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra, Linus Torvalds
When an spi driver's remove function returns a non-zero error code nothing happens apart from emitting a generic error message. Make this error message more device specific and return zero instead. Signed-off-by: Uwe Kleine-König <redacted> --- drivers/mtd/devices/mchp23k256.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
index 77c872fd3d83..23213009ebf4 100644
--- a/drivers/mtd/devices/mchp23k256.c
+++ b/drivers/mtd/devices/mchp23k256.c@@ -212,8 +212,15 @@ static int mchp23k256_probe(struct spi_device *spi) static int mchp23k256_remove(struct spi_device *spi) { struct mchp23k256_flash *flash = spi_get_drvdata(spi); + int ret; - return mtd_device_unregister(&flash->mtd); + ret = mtd_device_unregister(&flash->mtd); + if (ret) + /* There is nothing we can do about this ... */ + dev_warn(&spi->dev, "Failed to unregister mtd device (%pe)\n", + ERR_PTR(ret)); + + return 0; } static const struct of_device_id mchp23k256_of_table[] = {
--
2.30.2