Thread (23 messages) 23 messages, 8 authors, 2021-09-14

Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks]

From: Mark Brown <broonie@kernel.org>
Date: 2021-09-14 13:53:01
Also in: linux-arm-kernel, linux-clk, linux-pwm, linux-rtc, lkml

On Tue, Sep 14, 2021 at 03:22:56PM +0200, Uwe Kleine-König wrote:
On Thu, Aug 05, 2021 at 05:26:16PM -0700, Stephen Boyd wrote:
quoted
This proves why this topic is always contentious. It's too easy to
blindly convert drivers to get the clk and leave it enabled forever and
then they never use power management. The janitors win and nobody else.
If the janitors win and nobody else looses anything, this is fine for
me. And if in the future someone turns up who cares enough to improve
the converted drivers to a more efficient clock usage, they will
probably not stop their efforts just because then the driver uses
devm_clk_get_enabled.
The patterns that concern me are people either blindly converting to
devm without checking for other usage and causing problems as a result
(some of the janitorial stuff is done very mechanically) or thinking
it's important to keep devm_ used (or not thinking through the
interaction) and trying to do that while doing something more active.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help