Thread (2 messages) 2 messages, 2 authors, 2021-08-11

[bug report] spi: mxic: patch for octal DTR mode support

flat view

From: Dan Carpenter <hidden>
Date: 2021-08-11 08:01:44

Hello Zhengxun Li,

The patch d05aaa66ba3c: "spi: mxic: patch for octal DTR mode support"
from Aug 4, 2021, leads to the following
Smatch static checker warning:

	drivers/spi/spi-mxic.c:403 mxic_spi_mem_exec_op()
	warn: curly braces intended?

drivers/spi/spi-mxic.c
    390 	if (op->addr.nbytes)
    391 		ss_ctrl |= OP_ADDR_BYTES(op->addr.nbytes) |
    392 			   OP_ADDR_BUSW(fls(op->addr.buswidth) - 1) |
    393 			   (op->addr.dtr ? OP_ADDR_DDR : 0);
    394 
    395 	if (op->dummy.nbytes)
    396 		ss_ctrl |= OP_DUMMY_CYC(op->dummy.nbytes);
    397 
    398 	if (op->data.nbytes) {
    399 		ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) |
    400 			   (op->data.dtr ? OP_DATA_DDR : 0);
    401 		if (op->data.dir == SPI_MEM_DATA_IN)
    402 			ss_ctrl |= OP_READ;
--> 403 			if (op->data.dtr)
    404 				ss_ctrl |= OP_DQS_EN;

Probably you recieved or are about to recieve a bunc of static checker
warnings about curly braces or indenting here.  It's hard to know what
was intended.

    405 	}
    406 
    407 	writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select));
    408 

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help