RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Monday, March 1, 2021 8:14 PM
To: Kuldeep Singh <redacted>
Cc: devicetree@vger.kernel.org; Rob Herring <robh+dt@kernel.org>; Mark Brown
[off-list ref]; Ashish Kumar [off-list ref]; linux-
kernel@vger.kernel.org; linux-spi@vger.kernel.org
Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema

Caution: EXT Email

On Mon, 01 Mar 2021 15:34:06 +0530, Kuldeep Singh wrote:

quoted

Convert the NXP FlexSPI binding to DT schema format using json-schema.
Also, update MAINTAINERS to reflect the change.

Signed-off-by: Kuldeep Singh <redacted>
---
 .../bindings/spi/nxp,spi-nxp-fspi.yaml        | 101 ++++++++++++++++++
 .../devicetree/bindings/spi/spi-nxp-fspi.txt  |  42 --------
 MAINTAINERS                                   |   2 +-
 3 files changed, 102 insertions(+), 43 deletions(-)  create mode
100644 Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
 delete mode 100644
Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml:
properties:clocks:maxItems: False schema does not allow 2
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: ignoring,
error in schema: properties: clocks: maxItems
warning: no schema found in
file: ./Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
Error: Documentation/devicetree/bindings/spi/nxp,spi-nxp-
fspi.example.dts:26.31-32 syntax error FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:349:
Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dt.yaml] Error
1
make: *** [Makefile:1380: dt_binding_check] Error 2

See
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork
.ozlabs.org%2Fpatch%2F1445509&data=04%7C01%7Ckuldeep.singh%40nxp.
com%7Cb964d840a95e45dbf3cc08d8dcc08376%7C686ea1d3bc2b4c6fa92cd99c5c
301635%7C0%7C0%7C637502066681922692%7CUnknown%7CTWFpbGZsb3d8eyJ
WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
000&sdata=Ga5fpQ7oBEz8sQaA%2BtBZh75gPELe%2FDg6R5qJ2tZ2pB4%3D&
amp;reserved=0

This check can fail if there are any dependencies. The base for a patch series is
generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then
make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Thanks Rob for mentioning. I will make sure to run 'make dt_binding_check' before submitting next version.

Regards
Kuldeep