Re: [PATCH 8/8] spi: spi-s3c64xx: Turn on interrupts upon resume
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-08-19 12:53:10
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
Possibly related (same subject, not in this thread)
- 2020-08-19 · Re: [PATCH 8/8] spi: spi-s3c64xx: Turn on interrupts upon resume · Lukasz Stelmach <l.stelmach@samsung.com>
On Wed, Aug 19, 2020 at 02:32:08PM +0200, Łukasz Stelmach wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> --- drivers/spi/spi-s3c64xx.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 27db1e0f6f32..5dcad43fb847 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c@@ -1356,6 +1356,10 @@ static int s3c64xx_spi_runtime_resume(struct device *dev) s3c64xx_spi_hwinit(sdd); + writel(S3C64XX_SPI_INT_RX_OVERRUN_EN | S3C64XX_SPI_INT_RX_UNDERRUN_EN | + S3C64XX_SPI_INT_TX_OVERRUN_EN | S3C64XX_SPI_INT_TX_UNDERRUN_EN, + sdd->regs + S3C64XX_SPI_INT_EN); +
Makes sense but you should explain in the commit msg what happens without this (or why they are not enabled). Best regards, Krzysztof