Thread (1 message) 1 message, 1 author, 2012-02-03

Re: [PATCH 3/3] spi: create an optional message queueing infrastructure

From: Linus Walleij <hidden>
Date: 2012-02-03 14:00:23

Possibly related (same subject, not in this thread)

On Thu, Feb 2, 2012 at 5:05 PM, Mark Brown
[off-list ref] wrote:
[Me]
quoted
+ * This function checks if there is any spi message in the queue that
+ * needs processing and delegate control to appropriate function
+ * do_polling_transfer()/do_interrupt_dma_transfer()
+ * based on the kind of the transfer
This comment is bitrotted - the do_X_transfer functions are pl022
specific.  I had initially thought that this was another opportunity for
code sharing but it turns out that unlike the s3c64xx driver pl022 is
not switching between the two modes based on transfer size so we do need
different logic.
Yes atleast for now, I looked at the per-transfer pump we have
but I cannot right now figure out if that part can also be genericizied
so lets do it piecemal.

Fixing the comment in v2.

Thanks,
Linus Walleij

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help