Thread (6 messages) flat view 6 messages, 2 authors, 5d ago

Re: [PATCH 1/2] sh: Drop the selects of the removed CONFIG_USB_OHCI_SH symbol

From: Karl Mehltretter <hidden>
Date: 2026-09-05 15:06:38

On Sat, Sep 05, 2026 at 03:55:57PM +0100, Geert Uytterhoeven wrote:
quoted
        select CPU_HAS_DSP
        select SYS_SUPPORTS_SH_CMT
-       select USB_OHCI_SH if USB_OHCI_HCD
This is wrong, it should select USB_OHCI_HCD_PLATFORM instead.
Someone has already sent a patch for that[1], so it would be great if
that could be picked up instead.

[1] "[PATCH] sh: Use generic OHCI platform provider symbol"
    https://lore.kernel.org/20260624081926.12426-1-pengpeng@iscas.ac.cn/ (local)
Yes my patch is not "wrong" (doesn't make things worse) but clearly this 
is the proper solution.

So please consider both patches of this series withdrawn, the
defconfig change in 2/2 is covered by Pengpeng's patch as well.

I have resent Pengpeng's patch as v2 with his authorship kept:

https://lore.kernel.org/r/20260905145225.88518-1-kmehltretter@gmail.com/ (local)

Thanks,
Karl
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help