Thread (4 messages) read the whole thread 4 messages, 2 authors, 2016-08-20
STALE3633d

[PATCH] sh: Fix building j2_defconfig

From: Jason Cooper <hidden>
Date: 2016-08-16 15:42:04
Also in: lkml
Subsystem: superh, the rest · Maintainers: Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz, Linus Torvalds

When targeting the j2, we need to retain '-m2'.  Previously, the
Makefile blew out -m2 on the next line via :=.

Fix this by s/:=/+=/ when building for the J2.

Fixes: 5a846abad07f6 ("sh: add support for J-Core J2 processor")
Signed-off-by: Jason Cooper <redacted>
---
Thanks to Richard Felker for helping me locate the problem.

 arch/sh/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index 00476662ac2c..336f33a419d9 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -31,7 +31,7 @@ isa-y					:= $(isa-y)-up
 endif
 
 cflags-$(CONFIG_CPU_SH2)		:= $(call cc-option,-m2,)
-cflags-$(CONFIG_CPU_J2)			:= $(call cc-option,-mj2,)
+cflags-$(CONFIG_CPU_J2)			+= $(call cc-option,-mj2,)
 cflags-$(CONFIG_CPU_SH2A)		+= $(call cc-option,-m2a,) \
 					   $(call cc-option,-m2a-nofpu,) \
 					   $(call cc-option,-m4-nofpu,)
-- 
2.9.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help