Thread (13 messages) 13 messages, 4 authors, 2014-09-03

Re: [PATCH 3/3 repost] clocksource: sh_tmu: Document r8a7779 binding

From: Simon Horman <horms@verge.net.au>
Date: 2014-09-03 01:05:49
Also in: linux-arm-kernel, linux-devicetree

On Wed, Aug 27, 2014 at 10:53:08AM +0100, Mark Rutland wrote:
On Wed, Aug 27, 2014 at 06:28:20AM +0100, Simon Horman wrote:
quoted
In general Renesas hardware is not documented to the extent
where the relationship between IP blocks on different SoCs can be assumed
although they may appear to operate the same way. Furthermore the
documentation typically does not specify a version for individual
IP blocks. For these reasons a convention of using the SoC name in place
of a version and providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings
for the drivers a number of drivers for Renesas hardware. The purpose
of this patch is to update the Renesas R-Car Timer Unit (TMU)
driver to follow this convention.

Signed-off-by: Simon Horman <redacted>

---
* I plan to follow up with a patch patch to use the new binding in the
  dtsi files for the r8a7779 SoC.
---
 Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
index 425d0c5..712ddfa 100644
--- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt
+++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
@@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels.
 
 Required Properties:
 
-  - compatible: must contain "renesas,tmu"
+  - compatible: must contain one of the following.
+    - "renesas,tmu" generic TMU
+    - "renesas,tmu-r8a7779" R8A7779 TMU
Similarly to patch 2, "one or more" and swap the order here?
Sure, will do.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help