Re: [PATCH 4/5] ARM: shmobile: r8a7791: Add IPMMU DT nodes

Hi Laurent,

On Sat, Mar 29, 2014 at 12:36 AM, Laurent Pinchart
[off-list ref] wrote:

+       ipmmu_sy0: mmu@e6280800 {
+               compatible = "renesas,ipmmu-vmsa";
+               reg = <0 0xe6280800 0 0x800>;

Shouldn't this be "reg = <0 0xe6280000 0 0x1000>", i.e. expose both
banks?

Is there any specific reason you're using the second bank of registers?
These may read as zero, depending on the SoC mode.

+               interrupts = <0 223 IRQ_TYPE_LEVEL_HIGH>;
+               status = "disabled";
+       };

Same comment for the other nodes.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds