Re: [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU

On Fri, Feb 28, 2014 at 4:24 PM, Laurent Pinchart
[off-list ref] wrote:

+/*
+ * VMSA that states in section B3.6.3 "Control of Secure or Non-secure memory

VMSA states

+ * access, Long-descriptor format" that the NStable bit being set in a table
+ * descriptor will result in the NStable and NS bits of all child entries being
+ * ignored and considered as being set. The IPMMU seems not to comply with this,
+ * as it generates a secure access page fault if any of the NStable and NS bits
+ * isn't set when running in non-secure mode.
+ */

+       /*
+        * TTBCR
+        * We use long descriptor, with inner-shareable WBWA tables and allocate

descriptors

+        * the whole 32-bit VA space to TTBR0.
+        */

+       /*
+        * Clear the error status flags. Unlike traditionnal interrupt flag

traditional

Sorry, only comments on the comments ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds