Re: [PATCH] phy-rcar-usb-gen2: add device tree support

Hello.

On 29-01-2014 10:22, Simon Horman wrote:

quoted

[snip]

quoted

quoted

quoted

+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+    { .compatible = "renesas,usb-phy-r8a7790", },
+    { .compatible = "renesas,rcar-gen2-usb-phy", },

quoted

quoted

    Frankly speaking, I don't understand the need for the clearly
duplicate entries.

quoted

Thanks, will look into remove it.
Anyone else have any comments on this?

I would like you to leave it there.

As we know the r8a7790 is an R-Car Gen2 SoC.  But there are other R-Car
Gen2 SoCs, such as the r8a7791, they it could plausibly make use of
rcar-gen2-usb-phy until the driver is updated with a usb-phy-r8a7791 entry.

    Why not just "update" the driver this way now, may I ask?

WBR, Sergei