Re: [PATCH 5/8] phy-rcar-usb-gen2: add device tree support

On 26/01/14 18:03, Sergei Shtylyov wrote:

Hello.

On 01/26/2014 07:49 PM, Ben Dooks wrote:

quoted

Add support for the phy-rcar-gen2-usb driver to be probed from device
tree.

quoted

Signed-off-by: Ben Dooks <redacted>
Reviewed-by: Ian Molton <redacted>
---
Fixes from v1:
    - use of_property_reasd-bool()
    - remove unused of_id variable

quoted

Cc: linux-usb@vger.kernel.org
Cc: linux-sh@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Simon Horman <horms@verge.net.au>
Cc: devicetree@vger.kernel.org
---
  drivers/usb/phy/phy-rcar-gen2-usb.c | 31
++++++++++++++++++++++++++-----
  1 file changed, 26 insertions(+), 5 deletions(-)

quoted

diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c

b/drivers/usb/phy/phy-rcar-gen2-usb.c
index db3ab34..d146388 100644

--- a/drivers/usb/phy/phy-rcar-gen2-usb.c
+++ b/drivers/usb/phy/phy-rcar-gen2-usb.c

[...]

quoted

@@ -203,16 +210,29 @@ static int rcar_gen2_usb_phy_probe(struct

platform_device *pdev)

[...]

quoted

+    if (of_id) {

    You've removed the variable but not its use. Have you tried to
compile this patch?

Thanks, already noticed that and produced v3.

I should not be let near git-rebase when hungry.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius