Re: [RFC v9 PATCH 03/21] memory-hotplug: store the node id in acpi_memory_device
From: Ni zhan Chen <hidden>
Date: 2012-09-28 03:21:54
Also in:
linux-acpi, linux-mm, linux-s390, linuxppc-dev, lkml, sparclinux
On 09/05/2012 05:25 PM, wency@cn.fujitsu.com wrote:
From: Wen Congyang <redacted> The memory device has only one node id. Store the node id when enable the memory device, and we can reuse it when removing the memory device.
one question: if use numa emulation, memory device will associated to one node or ...?
quoted hunk ↗ jump to hunk
CC: David Rientjes <rientjes@google.com> CC: Jiang Liu <redacted> CC: Len Brown <redacted> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> CC: Paul Mackerras <redacted> CC: Christoph Lameter <redacted> Cc: Minchan Kim <redacted> CC: Andrew Morton <akpm@linux-foundation.org> CC: KOSAKI Motohiro <redacted> CC: Yasuaki Ishimatsu <redacted> Signed-off-by: Wen Congyang <redacted> Reviewed-by: Yasuaki Ishimatsu <redacted> --- drivers/acpi/acpi_memhotplug.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c index 2a7beac..7873832 100644 --- a/drivers/acpi/acpi_memhotplug.c +++ b/drivers/acpi/acpi_memhotplug.c@@ -83,6 +83,7 @@ struct acpi_memory_info { struct acpi_memory_device { struct acpi_device * device; unsigned int state; /* State of the memory device */ + int nid; struct list_head res_list; };@@ -256,6 +257,9 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device) info->enabled = 1; num_enabled++; } + + mem_device->nid = node; + if (!num_enabled) { printk(KERN_ERR PREFIX "add_memory failed\n"); mem_device->state = MEMORY_INVALID_STATE;