Re: [PATCH] ARM: shmobile: mackerel: fixup usb module order

On Mon, Aug 27, 2012 at 05:41:13PM +0900, Simon Horman wrote:

On Mon, Aug 06, 2012 at 05:19:12PM +0900, Simon Horman wrote:

quoted

On Sun, Aug 05, 2012 at 10:47:00PM -0700, Kuninori Morimoto wrote:

quoted

renesas_usbhs driver can play role as both Host and Gadget.
In case of Gadget, it requires not only renesas_usbhs
but also usb gadget module (like g_ether).
So, renesas_usbhs driver calls usb_add_gadget_udc() on probe time.

Because of this behavior,
Host port plays also Gadget role if kernel has both Host/Gadget support.

In mackerel case, from 0ada2da51800a4914887a9bcf22d563be80e50be
(ARM: mach-shmobile: mackerel: use renesas_usbhs instead of r8a66597_hcd)
usb0 plays Gadget role, and usb1 plays Host role,
and current mackerel board probes as usb1 -> usb0.
Thus, 1st installed usb gadget module (like g_ether) will be
assigned to usb1 (= usb Host port), and 2nd module to usb0 (= usb Gadget port).
It is very confusable for user.
This patch fixup usb modes probing order as usb0 -> usb1.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Simon Horman <horms@verge.net.au>

I have pushed this to the mackerel branch of my renesas tree,
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git

I will endeavour to get it included in 3.7.

On further consideration I have moved this patch to the
fixes branch (and removed the now empty mackerel branch).

I will endeavour to get it included in 3.6.