Re: [PATCH 4/5 v4] mmc: sh_mmcif: remove redundant .down_pwr() callback

Hi Simon

On Wed, 20 Jun 2012, Simon Horman wrote:

On Wed, Jun 13, 2012 at 03:37:27PM +0200, Guennadi Liakhovetski wrote:

quoted

quoted

From the original version of sh_mmcif the .set_pwr() callback has only been

used to turn the card's power on, and the .down_pwr() callback has been
used to turn it off. .set_pwr() can be used for both these tasks, which is
also how it is implemented by the only user of this API: the SH7724 ecovec
board.

Signed-off-by: Guennadi Liakhovetski <redacted>

Reviewed-by: Simon Horman <horms@verge.net.au>

Do you also intend to post patches for the following?

* Remove mmcif_down_pwr from ecovec
* Remove down_pwr from struct sh_mmcif_plat_data

Sure, since these patches depend on each other we have to make sure this 
one gets applied first. The other two then can be applied in their time, 
they do not affect the functionality any more.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/