Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2)

On Friday, September 30, 2011, Jean Pihet wrote:

Hi Rafael,

On Thu, Sep 29, 2011 at 10:33 PM, Rafael J. Wysocki [off-list ref] wrote:

quoted

Hi,

On Thursday, September 29, 2011, Jean Pihet wrote:

quoted

Hi Rafael,

I have a few minor remarks, inlined below.

In the meantime it turned out that the patch caused a build failure
for CONFIG_PM_SLEEP unset (your original patches won't really work
in this case too), so I posted a patch to fix it.  However, since
you had remarks anyway, I've simply folded the fix into the next
version of the $subject patch, which is appended.

OK to me.

I have 2 remarks though:
- some drivers are using the power_state field in the suspend/resume
operation, IIUC without conflict. Can you confirm?

Yes, I can.  There are no conflicts.

- the power_state field is scheduled for removal, cf.
Documentation/feature-removal-schedule.txt. That does not look
correct.

It still is schediled for removal, but we can't remove it right now
anyway because of the users mentioned above.  I'll replace this field
with a one-bit flag when we're ready to drop it (some time in future).

Thanks,
Rafael