Thread (17 messages) 17 messages, 2 authors, 2011-08-16

Re: [PATCH 3/5] mmc: sdhi: Add defines for platform irq indexes

From: Simon Horman <horms@verge.net.au>
Date: 2011-08-16 08:03:04
Also in: linux-mmc

On Tue, Aug 16, 2011 at 09:51:00AM +0200, Guennadi Liakhovetski wrote:
On Tue, 16 Aug 2011, Simon Horman wrote:
quoted
This is intended to make it easier to correctly
order platform defines in platform data and
the logic that uses them.

Cc: Guennadi Liakhovetski <redacted>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Paul Mundt <redacted>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 include/linux/mmc/sh_mobile_sdhi.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/linux/mmc/sh_mobile_sdhi.h b/include/linux/mmc/sh_mobile_sdhi.h
index bd50b36..c66c58c 100644
--- a/include/linux/mmc/sh_mobile_sdhi.h
+++ b/include/linux/mmc/sh_mobile_sdhi.h
@@ -3,6 +3,10 @@
 
 #include <linux/types.h>
 
+#define SH_MOBILE_SDHI_IRQ_SDCARD	0
+#define SH_MOBILE_SDHI_IRQ_CARD_DETECT	1
+#define SH_MOBILE_SDHI_IRQ_SDIO		2
+
An idea: make this an enum, put SH_MOBILE_SDHI_IRQ_NUMBER as a last item 
and use it in sh_mobile_sdhi_remove() as

	for (i = 0; i < SH_MOBILE_SDHI_IRQ_NUMBER; i++) {
Sure.
? I would also merge it with PATCH 4/5.
I prefer to keep it separate as 5/5 also depends on this change
and that is a change for a different maintainer.
quoted
 struct platform_device;
 struct tmio_mmc_data;
 
-- 
1.7.5.4
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help