Re: [PATCH 08/08] sh: Move new memblock reservation code to drivers/sh
From: Magnus Damm <magnus.damm@gmail.com>
Date: 2011-01-07 01:15:22
On Fri, Jan 7, 2011 at 1:02 AM, Masao Uebayashi [off-list ref] wrote:
On Thu, Jan 06, 2011 at 07:16:59PM +0900, Magnus Damm wrote:quoted
From: Magnus Damm <redacted> Move the new physically contiguous memory reservation code from arch/sh into drivers/sh/memchunk.c to it can be shared with SH-Mobile / R-Mobile ARM processors. Signed-off-by: Magnus Damm <redacted> --- arch/sh/mm/consistent.c | 58 ---------------------------------- drivers/sh/Makefile | 1 drivers/sh/memchunk.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 58 deletions(-)
Hi Uebayashi-san,
Why do you have two copies of shmobile_memchunk_setup() in arch/sh/mm/consistent.c and here? Masao (new to this list)
The patch should move the function into drivers/sh, but perhaps I made some mistake. So there shouldn't be two copies of the same function, not sure how you get that. Thanks, / magnus