Re: [RFC] [PATCH] arm & sh: factorised duplicated clkdev.c

On Wed, Sep 01, 2010 at 05:01:12PM +0200, Uwe Kleine-König wrote:

On Wed, Sep 01, 2010 at 01:18:46PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:

quoted

quoted

quoted

 
-struct clk_lookup *clkdev_alloc(struct clk *clk, const char *con_id,
-	const char *dev_fmt, ...)
+struct clk_lookup * __init_refok

Why do you need __init_refok?  __init_refok is defined as follows in
include/linux/init.h:

	/* compatibility defines */
	#define __init_refok     __ref

So if really needed better use __ref.  Couldn't this be __init?  

ok for __ref but __init_refok is more clear IMHO

For me it was not, because before your mail I didn't know __init_refok
so I had to look it up.

quoted

and yes we need it as for early device we may use bootmem as slab allocators
may no be availlable in some case

Yes I got that, but it doesn't explain why you need to mark your
function as __ref or why you cannot use __init.

You can't use __init for this because this function may be used for
non-init code.