Re: [PATCH 01/36] tty: xtensa/iss: drop unneeded tty_operations hooks

From
Max Filippov <jcmvbkbc@gmail.com>
Date
2023-08-10 12:37:49
Also in
lkml
Reply to
Jiri Slaby (SUSE), 2023-08-10
On Thu, Aug 10, 2023 at 2:15 AM Jiri Slaby (SUSE) [off-list ref] wrote:
All ::flush_chars(), ::hangup(), and ::wait_until_sent() from struct
tty_operations are optional. There is no need to provide them with
empty bodies.

tty_operations::put_char() needs not be provided if it is the same as
tty_operations::write(tty, &ch, 1).

So drop all of them.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Chris Zankel <chris@zankel.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>
---
 arch/xtensa/platforms/iss/console.c | 24 ------------------------
 1 file changed, 24 deletions(-)
Acked-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max
Thread (68 messages) 68 messages, 11 authors, last reply 2023-08-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help