Re: [PATCH] serial: lantiq: store and compare return status correctly

On Tue, Dec 21, 2021 at 2:42 PM Muhammad Usama Anjum
[off-list ref] wrote:

platform_get_irq() returns signed status. It should be stored and
compared as signed value before storing to unsigned variable. Implicit
conversion from signed to unsigned and then comparison with less than
zero is wrong as unsigned value can never be less than zero.

Fixes: f087f01ca2 ("serial: lantiq: Use platform_get_irq() to get the interrupt")
Signed-off-by: Muhammad Usama Anjum <redacted>
---
 drivers/tty/serial/lantiq.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

Thanks for fixing this.

Acked-by: Rob Herring <robh@kernel.org>