Re: [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-06 13:47:53
Also in:
kernel-janitors, lkml
On Sun, Dec 05, 2021 at 11:28:22PM +0000, Colin Ian King wrote:
The variable tmp is being masked with a bitmask and the value is being written to port base + 0x3c. However, the masked value is being written back to tmp and tmp is never used after this. The assignmentment is redundant, replace the &= operator with just &.
Make sense (maybe you can replace all those 0x00...BIT...00 by BIT() and GENMASK() later on). Reviewesd-by: Andy Shevchenko [off-list ref]
quoted hunk ↗ jump to hunk
Signed-off-by: Colin Ian King <redacted> --- drivers/tty/serial/8250/8250_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 60f8fffdfd77..81aac3c25ead 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c@@ -1278,7 +1278,7 @@ static int pci_quatech_init(struct pci_dev *dev) outl(inl(base + 0x38) | 0x00002000, base + 0x38); tmp = inl(base + 0x3c); outl(tmp | 0x01000000, base + 0x3c); - outl(tmp &= ~0x01000000, base + 0x3c); + outl(tmp & ~0x01000000, base + 0x3c); } } return 0;-- 2.33.1
-- With Best Regards, Andy Shevchenko