Re: [PATCH 1/1] tty: serial: uartlite: allow 64 bit address

On Tue, Nov 23, 2021 at 12:12:06PM -0800, Lizhi Hou wrote:

On 11/23/21 10:59 AM, Greg KH wrote:

quoted

On Tue, Nov 23, 2021 at 10:45:06AM -0800, Lizhi Hou wrote:

quoted

Fix the uartlite probe failure when it is mapped to address above 4G.

Fix it how?

Does this detail comment look ok to you?

The base address of uartlite registers could be 64 bit address which is from
device resource. When ulite_probe() calls ulite_assign(), this 64 bit
address is casted to 32-bit. The fix is to replace "u32" type with
"phys_addr_t" type for the base address in ulite_assign() argument list.

Much better.

quoted

quoted

Signed-off-by: Lizhi Hou <redacted>

What commit caused this problem?  What commit does this fix?  Should it
go to stable kernels?

I searched the history. This problem was introduced by https://github.com/torvalds/linux/commit/8fa7b6100693e0b648ffd34564f6f41226502a19

And yes, I agree this should go to stable kernels. I will add
stable@vger.kernel.org to cc list.

Thank you, please add a Fixes: tag to the patch as well when you
resubmit it.

greg k-h