Thread (6 messages) flat view 6 messages, 3 authors, 2021-11-24

Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()

From: Uwe Kleine-König <hidden>
Date: 2021-11-23 13:03:23
Also in: lkml

On Tue, Nov 23, 2021 at 06:51:22PM +0800, Sherry Sun wrote:
From: Fugang Duan <redacted>

Disable the UCR4_OREN bit in .stop_rx() before the uart receiver is disabled
maybe better than in the .shutdown() function.
There should be a better incentive than "maybe it's better to do this".
My expectation is that you verify there is indeed an issue and then fix
that with a descriptive commit log that convinces this is indeed a fix.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help