Re: [PATCH] tty: serial: atmel: Check return code of dmaengine_submit()
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-11-15 15:58:40
Also in:
linux-arm-kernel, lkml
On Mon, Nov 15, 2021 at 04:30:04PM +0200, Tudor Ambarus wrote:
dma_cookie_t < 0 indicates an error code, check for it.
Very odd changelog text, please be more descriptive about what is happening here.
quoted hunk ↗ jump to hunk
Signed-off-by: Tudor Ambarus <redacted> --- drivers/tty/serial/atmel_serial.c | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 2c99a47a2535..376f7a9c2868 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c@@ -1004,6 +1004,11 @@ static void atmel_tx_dma(struct uart_port *port) desc->callback = atmel_complete_tx_dma; desc->callback_param = atmel_port; atmel_port->cookie_tx = dmaengine_submit(desc); + if (dma_submit_error(atmel_port->cookie_tx)) { + dev_err(port->dev, "dma_submit_error %d\n", + atmel_port->cookie_tx); + return;
What can a user do with this error message? Have you seen this happen in real life? What commit does this "fix"? thanks, greg k-h