Re: [PATCH 11/11] dmaengine: remove slave_id config field
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2021-11-15 09:20:10
Also in:
alsa-devel, dmaengine, dri-devel, linux-arm-kernel, linux-arm-msm, linux-mmc, linux-spi, linux-staging, linux-tegra, lkml
Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:54:03AM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de> All references to the slave_id field have been removed, so remove the field as well to prevent new references from creeping in again.
A rationale to explain why the slave_id field shouldn't be used would be nice.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk ↗ jump to hunk
--- include/linux/dmaengine.h | 4 ---- 1 file changed, 4 deletions(-)diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 9000f3ffce8b..0349b35235e6 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h@@ -418,9 +418,6 @@ enum dma_slave_buswidth { * @device_fc: Flow Controller Settings. Only valid for slave channels. Fill * with 'true' if peripheral should be flow controller. Direction will be * selected at Runtime. - * @slave_id: Slave requester id. Only valid for slave channels. The dma - * slave peripheral will have unique id as dma requester which need to be - * pass as slave config. * @peripheral_config: peripheral configuration for programming peripheral * for dmaengine transfer * @peripheral_size: peripheral configuration buffer size@@ -448,7 +445,6 @@ struct dma_slave_config { u32 src_port_window_size; u32 dst_port_window_size; bool device_fc; - unsigned int slave_id; void *peripheral_config; size_t peripheral_size; };
-- Regards, Laurent Pinchart