Re: [PATCH v4] tty: vt: keyboard: add default switch-case, to handle smatch-warnings in method vt_do_kdgkb_ioctl

On 07. 11. 21, 4:17, Ajay Garg wrote:

smatch-kchecker gives the following warnings when run on keyboard.c :

vt_do_kdgkb_ioctl() error: uninitialized symbol 'kbs'.
vt_do_kdgkb_ioctl() error: uninitialized symbol 'ret'.

This usually happens when switch has no default case and static
analyzers and even sometimes compilers can’t prove that all possible
values are covered.


Thus, the default switch-case has been added, which sets the values
for the two variables :

Just to shut up random static analyzers? Please don't.


-- 
js
suse labs