Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock
From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-10-15 00:13:08
Also in:
linux-arm-kernel, linux-clk, linux-devicetree, lkml
Quoting Pali Rohár (2021-09-30 02:58:35)
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml b/Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml new file mode 100644 index 000000000000..175f5c8f2bc5 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml@@ -0,0 +1,59 @@
[..]
+ '#clock-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ uartclk: clock-controller@12010 {The uart device is at 0x12000 and the clock-controller is at 0x12010? This looks like a node is being put into DT to represent a clk driver. Why can't we register a clk from the uart device driver itself? I think we talked about this a month or two ago but it still isn't clear to me.
+ compatible = "marvell,armada-3700-uart-clock"; + reg = <0x12010 0x4>, <0x12210 0x4>; + clocks = <&tbg 0>, <&tbg 1>, <&tbg 2>, <&tbg 3>, <&xtalclk>; + clock-names = "TBG-A-P", "TBG-B-P", "TBG-A-S", "TBG-B-S", "xtal"; + #clock-cells = <1>; + }; -- 2.20.1