Thread (3 messages) 3 messages, 3 authors, 2021-10-07

Re: [PATCH] tty: serial: atmel: use macros instead of hardcoded values

From: Richard Genoud <hidden>
Date: 2021-10-07 13:36:07
Also in: linux-arm-kernel, lkml

Le 07/10/2021 à 13:20, Claudiu Beznea a écrit :
Use UART_PM_STATE_ON, UART_PM_STATE_OFF instead of hardcoded values.

Signed-off-by: Claudiu Beznea <redacted>
Acked-by: Richard Genoud <redacted>
quoted hunk ↗ jump to hunk
---
  drivers/tty/serial/atmel_serial.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 249ea35088d2..2c99a47a2535 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -2084,7 +2084,7 @@ static void atmel_serial_pm(struct uart_port *port, unsigned int state,
  	struct atmel_uart_port *atmel_port = to_atmel_uart_port(port);
  
  	switch (state) {
-	case 0:
+	case UART_PM_STATE_ON:
  		/*
  		 * Enable the peripheral clock for this serial port.
  		 * This is called on uart_open() or a resume event.
@@ -2094,7 +2094,7 @@ static void atmel_serial_pm(struct uart_port *port, unsigned int state,
  		/* re-enable interrupts if we disabled some on suspend */
  		atmel_uart_writel(port, ATMEL_US_IER, atmel_port->backup_imr);
  		break;
-	case 3:
+	case UART_PM_STATE_OFF:
  		/* Back up the interrupt mask and disable all interrupts */
  		atmel_port->backup_imr = atmel_uart_readl(port, ATMEL_US_IMR);
  		atmel_uart_writel(port, ATMEL_US_IDR, -1);
Thanks !
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help