On Wed, Sep 29, 2021 at 10:07:47PM +0200, Uwe Kleine-König wrote:

On Fri, Feb 05, 2021 at 04:20:00PM +0200, Andy Shevchenko wrote:

quoted

On Thu, Feb 04, 2021 at 11:11:55AM -0500, Eric Tremblay wrote:

quoted

Thanks everyone for the comments. I apply most of the comments on version 1
but there is still a pending point with the Jiri comment about the safety of:
struct tty_struct *tty = p->port.state->port.tty;
I thought about adding a check with tty_port_initialized() before accessing
the pointer, but I saw some other places where that same pointer is accessed
without further protection, at least from what I see.

Thanks for the update. Unfortunately I'm a bit busy with other prioritized
stuff, but I will review this next week.

I assume this fell through the cracks as "next week" is already over ...?

Indeed. Anyways, there is a kbuildbot message against patch 1 as I see and
needs to be addressed. I'm going to look into the code right now.

-- 
With Best Regards,
Andy Shevchenko