On Tue, Sep 21, 2021 at 05:51:35PM +0200, Jiri Slaby wrote:

On 21. 09. 21, 13:36, Greg KH wrote:

quoted

On Tue, Sep 21, 2021 at 12:52:38PM +0200, Jiri Slaby wrote:

quoted

On 21. 09. 21, 6:00, Dmitry Torokhov wrote:

quoted

Hi Jiri,

On Tue, Sep 14, 2021 at 11:11:25AM +0200, Jiri Slaby wrote:

quoted

diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c
index 17eb8f2aa48d..55e91d0e70ec 100644
--- a/drivers/input/serio/serport.c
+++ b/drivers/input/serio/serport.c

@@ -207,8 +207,8 @@ static void serport_set_type(struct tty_struct *tty, unsigned long type)
    * serport_ldisc_ioctl() allows to set the port protocol, and device ID
    */
-static int serport_ldisc_ioctl(struct tty_struct *tty, struct file *file,
-			       unsigned int cmd, unsigned long arg)
+static int serport_ldisc_ioctl(struct tty_struct *tty, unsigned int cmd,
+		unsigned long arg)

Can we please keep arguments aligned as they were? Otherwise

Fixed, thanks. Likely, I will send a follow-up -- depending if Greg drops or
keeps these in the tree.

Up to you.  I can drop them all now if you want to resend a v2 with all
of the aggregate acks, or you can send a follow-up set on top of these.

What about if you keep everything up to (and incl.)
  tty: remove file from n_tty_ioctl_helper
(i.e. the patch 06/16, the one before this one)? If that works for you, I
will send v2 of the rest w/ collected acks. If it doesn't, I prefer sending
a complete v2 (incl. collected acks).

Ok, I have kept everything up to and including patch 06 of this series
and pushed that out now.

Feel free to rebase on my tty-next branch and resend the remaining
changes.

thanks,

greg k-h