Thread (5 messages) 5 messages, 3 authors, 2021-07-29

Re: [PATCH] tty: serial: uartlite: Use read_poll_timeout for a polling loop

From: Sean Anderson <hidden>
Date: 2021-07-29 15:31:31


On 7/29/21 10:59 AM, Greg Kroah-Hartman wrote:
On Fri, Jul 23, 2021 at 05:52:20PM -0400, Sean Anderson wrote:
quoted
This uses read_poll_timeout_atomic to spin while waiting on uart_in32.
That says what you are doing, but nothing about _why_ you are making
this change.  Please fix up.
Ok, how about

read_poll_timeout was recently introduced, and can be used to simplify
our console polling loop. This results in a slight reduction in code.
early_uartlite_putc can't get the same treatment, because it can be
called before udelay is set up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help