Thread (12 messages) 12 messages, 6 authors, 2021-07-27

Re: [PATCH] serial: 8250: 8250_omap: Fix possible interrupt storm

From: Tony Lindgren <tony@atomide.com>
Date: 2021-07-27 10:39:12
Also in: linux-arm-kernel, linux-omap, lkml

* Andy Shevchenko [off-list ref] [210713 09:14]:
On Tue, Jul 13, 2021 at 11:54 AM Vignesh Raghavendra [off-list ref] wrote:
quoted
On 7/13/21 1:57 AM, andy@surfacebook.localdomain wrote:
quoted
Tue, Jun 22, 2021 at 11:53:38AM +0530, Vignesh Raghavendra kirjoitti:
...
quoted
quoted
https://lore.kernel.org/linux-serial/20170206233000.3021-1-dianders@chromium.org/ (local)
I am not sure if reading UART_LSR is a good idea in the above patch.
Some flags in LSR register are cleared on read (at least that's the case
for UARTs on TI SoCs) and thus can result in loss of error/FIFO status
information.
quoted
https://lore.kernel.org/linux-serial/1440015124-28393-1-git-send-email-california.l.sullivan@intel.com/ (local)
Looks like this never made it.
Forgot to react to the above. Yes, they never made it because I
believe due to the exact reason you mentioned above. Also California
set up different experiments IIRC and it shows that the problem didn;t
fully disappear with his approach. But maybe yours will work better
(at least it's not the first time I have seen it on different hardware
according to people's contributions).
Not sure if this is the same issue with noisy lines, but see also the
following in case it's related:

[PATCH 2/2] serial: 8250_omap: Handle optional overrun-throttle-ms property

Also available at [0] below.

Regards,

Tony

[0] https://lore.kernel.org/linux-omap/20210727103533.51547-1-tony@atomide.com/T/#m5f9da26c32503f2937d3d5977310ca337fa0cb5a (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help