Thread (22 messages) 22 messages, 8 authors, 2021-07-27

Re: [PATCH 4/8] tty: stop using alloc_tty_driver

From: Samuel Iglesias Gonsálvez <hidden>
Date: 2021-07-23 07:50:11
Also in: lkml

On Fri, 2021-07-23 at 09:43 +0200, Jiri Slaby wrote:
alloc_tty_driver was deprecated by tty_alloc_driver in commit
7f0bc6a68ed9 (TTY: pass flags to alloc_tty_driver) in 2012.

I never got into eliminating alloc_tty_driver until now. So we still
have two functions for allocating drivers which might be confusing.
So
get rid of alloc_tty_driver uses to eliminate it for good in the next
patch.

Note we need to switch return value checking as tty_alloc_driver uses
ERR_PTR. And flags are now a parameter of tty_alloc_driver.

Signed-off-by: Jiri Slaby <redacted>
Cc: Richard Henderson <redacted>(odd fixer:ALPHA PORT)
Cc: Ivan Kokshaysky <redacted>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Helge Deller <deller@gmx.de>
Cc: Jeff Dike <redacted>
Cc: Richard Weinberger <richard@nod.at>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Samuel Iglesias Gonsalvez <redacted>
Cc: Jens Taprogge <jens.taprogge@taprogge.org>
Cc: Karsten Keil <redacted>
Cc: Ulf Hansson <redacted>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Christian Borntraeger <redacted>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: David Sterba <dsterba@suse.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Oliver Neukum <oneukum@suse.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Johan Hovold <johan@kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <redacted>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
---
 arch/alpha/kernel/srmcons.c            |  6 +++---
 arch/m68k/emu/nfcon.c                  |  7 +++----
 arch/parisc/kernel/pdc_cons.c          |  9 ++++-----
 arch/um/drivers/line.c                 | 11 ++++++-----
 arch/xtensa/platforms/iss/console.c    |  7 +++----
 drivers/ipack/devices/ipoctal.c        |  9 ++++-----
 drivers/isdn/capi/capi.c               | 10 ++++------
 drivers/mmc/core/sdio_uart.c           |  8 ++++----
 drivers/net/usb/hso.c                  |  8 ++++----
 drivers/s390/char/con3215.c            |  7 +++----
 drivers/s390/char/sclp_tty.c           |  7 +++----
 drivers/s390/char/sclp_vt220.c         |  7 +++----
 drivers/staging/gdm724x/gdm_tty.c      |  9 ++++-----
 drivers/tty/amiserial.c                |  7 +++----
 drivers/tty/ehv_bytechan.c             |  8 ++++----
 drivers/tty/goldfish.c                 | 14 +++++++-------
 drivers/tty/hvc/hvc_console.c          |  8 ++++----
 drivers/tty/hvc/hvcs.c                 |  8 ++++----
 drivers/tty/hvc/hvsi.c                 |  7 +++----
 drivers/tty/ipwireless/tty.c           |  8 ++++----
 drivers/tty/mxser.c                    |  8 ++++----
 drivers/tty/n_gsm.c                    |  9 ++++-----
 drivers/tty/nozomi.c                   |  8 ++++----
 drivers/tty/serial/kgdb_nmi.c          |  7 +++----
 drivers/tty/serial/serial_core.c       |  8 +++++---
 drivers/tty/synclink_gt.c              |  8 ++++----
 drivers/tty/vt/vt.c                    |  6 +++---
 drivers/usb/class/cdc-acm.c            |  8 ++++----
 drivers/usb/gadget/function/u_serial.c |  8 ++++----
 drivers/usb/serial/usb-serial.c        |  9 ++++-----
 net/bluetooth/rfcomm/tty.c             |  8 ++++----
 31 files changed, 120 insertions(+), 132 deletions(-)
For ipack changes:

Acked-by: Samuel Iglesias Gonsálvez <redacted>

Sam

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help