Re: [PATCH v1 3/4] serial: 8250_pci: Always try MSI/MSI-X
From: <hidden>
Date: 2021-07-14 16:57:15
Also in:
lkml
From: <hidden>
Date: 2021-07-14 16:57:15
Also in:
lkml
On Wed, Jul 14, 2021 at 12:15:25PM +0300, Andy Shevchenko wrote:
On Wed, Jul 14, 2021 at 9:55 AM Jiri Slaby [off-list ref] wrote: ... Thanks, but I still think that blacklisting is better. All drivers I have split (or participated in splitting) from 8250_pci have enabled MSI for the entire subset they serve for. ... Thanks. I also added Randy, who extended the list.
My own opinion is that a whitelist to enroll devices as they are tested is the safer approach, for the reason that getting test coverage on many of the older devices would be difficult. For example, I see id's of HP devices in the code that are probably 20 years old, and I doubt whether there are operational examples inside HPE today. That said, I can offer to test that a new patch to 8250_pci.c works on the device I recently added. Please cc me directly if that is helpful, as I don't always read the mailing lists such as linux-serial promptly. -- Randy Wright - Hewlett Packard Enterprise - rwright@hpe.com