Re: [PATCH] serial: 8250_pci: Use fallthrough pseudo-keyword
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-05-07 13:21:02
Also in:
lkml
On Fri, May 07, 2021 at 09:04:03PM +0800, Wei Ming Chen wrote:
quoted hunk ↗ jump to hunk
Add pseudo-keyword macro fallthrough[1] [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Wei Ming Chen <redacted> --- drivers/tty/serial/8250/8250_pci.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 689d8227f95f..4158f06de4d5 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c@@ -847,8 +847,11 @@ static int pci_netmos_init(struct pci_dev *dev) switch (dev->device) { /* FALLTHROUGH on all */ case PCI_DEVICE_ID_NETMOS_9904: + fallthrough; case PCI_DEVICE_ID_NETMOS_9912: + fallthrough; case PCI_DEVICE_ID_NETMOS_9922: + fallthrough; case PCI_DEVICE_ID_NETMOS_9900:
I really doubt this is needed here. If so, something is really wrong with the static checkers. thanks, greg k-h