Thread (14 messages) 14 messages, 3 authors, 2021-05-21
STALE1853d

[PATCH 01/11] tty: serial: 21285: Fix some coding sytle issues

From: Jay Fang <f.fangjian@huawei.com>
Date: 2021-05-18 01:57:28
Subsystem: the rest, tty layer and serial drivers · Maintainers: Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby

From: Zihao Tang <redacted>

Fix the following coding style issues reported by checkpatch.pl:

  ERROR: trailing whitespace
  #265: FILE: ./drivers/tty/serial/21285.c:265:
  +^Ibaud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); $

  ERROR: that open brace { should be on the previous line
  #483: FILE: ./drivers/tty/serial/21285.c:483:
  +static struct console serial21285_console =
  +{

  ERROR: Macros with complex values should be enclosed in parentheses
  #501: FILE: ./drivers/tty/serial/21285.c:501:
  +#define SERIAL_21285_CONSOLE	&serial21285_console

Signed-off-by: Zihao Tang <redacted>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/tty/serial/21285.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/21285.c b/drivers/tty/serial/21285.c
index 09baef4..bb323a7 100644
--- a/drivers/tty/serial/21285.c
+++ b/drivers/tty/serial/21285.c
@@ -262,7 +262,7 @@ serial21285_set_termios(struct uart_port *port, struct ktermios *termios,
 	/*
 	 * Ask the core to calculate the divisor for us.
 	 */
-	baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); 
+	baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16);
 	quot = uart_get_divisor(port, baud);
 	b = port->uartclk / (16 * quot);
 	tty_termios_encode_baud_rate(termios, b, b);
@@ -479,8 +479,7 @@ static int __init serial21285_console_setup(struct console *co, char *options)
 
 static struct uart_driver serial21285_reg;
 
-static struct console serial21285_console =
-{
+static struct console serial21285_console = {
 	.name		= SERIAL_21285_NAME,
 	.write		= serial21285_console_write,
 	.device		= uart_console_device,
@@ -498,7 +497,7 @@ static int __init rs285_console_init(void)
 }
 console_initcall(rs285_console_init);
 
-#define SERIAL_21285_CONSOLE	&serial21285_console
+#define SERIAL_21285_CONSOLE	(&serial21285_console)
 #else
 #define SERIAL_21285_CONSOLE	NULL
 #endif
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help