Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs_check warrning
From: dillon min <hidden>
Date: 2021-03-19 11:14:41
Also in:
linux-arm-kernel, linux-devicetree, lkml
Hi Alexandre, Thanks for the reply. On Fri, Mar 19, 2021 at 4:38 PM Alexandre TORGUE [off-list ref] wrote:
Hi Dillon On 3/19/21 5:28 AM, dillon min wrote:quoted
No changes, Just loop lkp in. Hi lkp, Sorry for the late reply, thanks for your report. This patch is to fix the build warning message. Thanks. Regards On Mon, Mar 15, 2021 at 5:45 PM [off-list ref] wrote:quoted
From: dillon min <redacted> when run make dtbs_check with 'bluetoothi brcm,bcm43438-bt' dts enabled on stm32h7, there is a warrning popup:quoted
quoted
arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800: 'bluetooth'does not match any of the regexes: 'pinctrl-[0-9]+' to make dtbs_check happy, so add a phandle bluetooth Fixes: 500cdb23d608 ("ARM: dts: stm32: Add STM32H743 MCU and STM32H743i-EVAL board") Signed-off-by: dillon min <redacted> Reported-by: kernel test robot <redacted> --- Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml index 8631678283f9..5e674840e62d 100644 --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml@@ -50,6 +50,11 @@ properties: minItems: 1 maxItems: 2 + bluetooth: + type: object + description: | + phandles to the usart controller and bluetooth +Do we really need to add this "generic" property here ? You could test without the "AditionalProperties:False".
Yes, indeed. we have no reason to add a generic 'bluetooth' property into specific soc's interface yaml. I can't just remove "AditionalProperties:False", else make O=../kernel-art/ dtbs dtbs_check will run into /home/fmin/linux/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property ... So , i will replace "AditionalProperties:False". with unevaluatedProperties: false, do you agree with this? If so, i will send patch v4 later. Thanks. Regards
Regards Alexquoted
quoted
# cts-gpios and rts-gpios properties can be used instead of 'uart-has-rtscts' # or 'st,hw-flow-ctrl' (deprecated) for making use of any gpio pins for flow # control instead of dedicated pins. -- 1.9.1