Re: [PATCH] tty: serial: fix earlycon dependency
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2020-08-17 17:23:55
Also in:
lkml
On Mon, Aug 17, 2020 at 12:50:59PM -0400, Tong Zhang wrote:
parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon() in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON should automatically select SERIAL_CORE, otherwise will result in symbol not found error during linking if SERIAL_CORE is not configured as builtin
We can handle lines 72 characters long :)
Signed-off-by: Tong Zhang <redacted>
What broke to cause this to be needed? Can you provide a "Fixes:" tag for this?
quoted hunk ↗ jump to hunk
--- drivers/tty/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 8a0352eb337c..42e844314cbb 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig@@ -8,6 +8,7 @@ menu "Serial drivers" config SERIAL_EARLYCON bool + select SERIAL_CORE
Are you _sure_ about this? This feels odd... thanks, greg k-h