On Fri, Aug 07, 2020 at 09:18:57AM +0000, Johnson CH Chen (陳昭勳) wrote:

quoted

quoted

+	if (info->modem_control & UART_MCR_RTS)
+		nd->cmd_buffer[6] = 1;
+	else
+		nd->cmd_buffer[6] = 0;
+
+	if (termio->c_cflag & CRTSCTS) {
+		nd->cmd_buffer[7] = 1;
+		nd->cmd_buffer[8] = 1;
+	} else {
+		nd->cmd_buffer[7] = 0;
+		nd->cmd_buffer[8] = 0;
+	}
+
+	if (termio->c_iflag & IXON)
+		nd->cmd_buffer[9] = 1;
+	else
+		nd->cmd_buffer[9] = 0;
+
+	if (termio->c_iflag & IXOFF)
+		nd->cmd_buffer[10] = 1;
+	else
+		nd->cmd_buffer[10] = 0;

What is this cmd_buffer good for actually? Only to let the user know?
Then -- drop it.

Because detailed iterations for cmd_buffer and cmd_rsp with Nport
server device are regarded proprietary for our company, is it good to
reveal value of cmd_buffer[] with macros only for upstream this
driver?

There is nothing "proprietary" for Linux kernel code, sorry.  Please
document this properly so we can understand, review, and maintain it
over time correctly.

thanks,

greg k-h