RE: [EXT] Re: [PATCH tty/serial v3 2/2] tty: serial: imx: add imx earlycon driver
From: Andy Duan <hidden>
Date: 2020-08-05 03:52:21
From: Geert Uytterhoeven <geert@linux-m68k.org>
Hi Fugan, On Fri, Jul 24, 2020 at 9:17 AM Fugang Duan [off-list ref] wrote:quoted
Split imx earlycon driver from imx serial driver "imx.c" as separated driver. imx serial driver can be built as module, but earlycon driver only support build in. Signed-off-by: Fugang Duan <redacted>Thanks for your patch, which is now commit 699cc4dfd14071e4 ("tty: serial: imx: add imx earlycon driver") in tty-next.quoted
drivers/tty/serial/Kconfig | 8 +++++ drivers/tty/serial/imx_earlycon.c | 50 +++++++++++++++++++++++++++++++Seems like imx_earlycon.c is never built, as no Makefile update is included? Else this patch is just an obfuscated way to enable SERIAL_EARLYCON for all OF platforms? ;-)quoted
--- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig@@ -515,6 +515,14 @@ config SERIAL_IMX_CONSOLE "console=ttymxc0". (Try "man bootparam" or see thedocumentation ofquoted
your bootloader about how to pass options to the kernel at boot time.) +config SERIAL_IMX_EARLYCON + bool "Earlycon on IMX serial port" + depends on OFObviously this should depend on "ARCH_MXC || COMPILE_TEST".
I will submit another patch for it. Thanks!
quoted
+ select SERIAL_EARLYCON + help + If you have enabled the earlycon on the Freescale IMX + CPU you can make it the earlycon by answering Y to this option. + config SERIAL_UARTLITE tristate "Xilinx uartlite serial port support" depends on HAS_IOMEMGr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds