[PATCH] serial: sh-sci: Missing uart_unregister_driver() on error in sci_probe_single()
From: Mao Wenan <hidden>
Date: 2019-03-08 14:10:36
Also in:
kernel-janitors, lkml
Subsystem:
the rest, tty layer and serial drivers · Maintainers:
Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
Add the missing uart_unregister_driver() before return from sci_probe_single() in the error handling case. Signed-off-by: Mao Wenan <redacted> --- drivers/tty/serial/sh-sci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 64bbeb7d7e0c..dde4eac9d222 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c@@ -3254,8 +3254,10 @@ static int sci_probe_single(struct platform_device *dev, mutex_unlock(&sci_uart_registration_lock); ret = sci_init_single(dev, sciport, index, p, false); - if (ret) + if (ret) { + uart_unregister_driver(&sci_uart_driver); return ret; + } sciport->gpios = mctrl_gpio_init(&sciport->port, 0); if (IS_ERR(sciport->gpios) && PTR_ERR(sciport->gpios) != -ENOSYS)
--
2.20.1